split irc proejction into a separate crate (#18)

.gitea/workflows/test-pr.yml

@@ -16,4 +16,3 @@ jobs:
       uses: https://github.com/actions-rs/cargo@v1
       with:
         command: test
-        args: --workspace -- --skip projections::irc

Cargo.lock

@@ -857,8 +857,8 @@ dependencies = [
  "lavina-core",
  "mgmt-api",
  "nonempty",
+ "projection-irc",
  "prometheus",
- "proto-irc",
  "proto-xmpp",
  "quick-xml",
  "regex",
@@ -1252,6 +1252,21 @@ dependencies = [
  "yansi",
 ]
 
+[[package]]
+name = "projection-irc"
+version = "0.0.1-dev"
+dependencies = [
+ "anyhow",
+ "futures-util",
+ "lavina-core",
+ "nonempty",
+ "prometheus",
+ "proto-irc",
+ "serde",
+ "tokio",
+ "tracing",
+]
+
 [[package]]
 name = "prometheus"
 version = "0.13.3"

Cargo.toml

@@ -3,6 +3,7 @@ members = [
     ".",
     "crates/lavina-core",
     "crates/proto-irc",
+    "crates/projection-irc",
     "crates/proto-xmpp",
     "crates/mgmt-api",
 ]
@@ -25,6 +26,7 @@ clap = { version = "4.4.4", features = ["derive"] }
 serde = { version = "1.0.152", features = ["rc", "serde_derive"] }
 tracing = "0.1.37" # logging & tracing api
 prometheus = { version = "0.13.3", default-features = false }
+lavina-core = { path = "crates/lavina-core" }
 
 [package]
 name = "lavina"
@@ -50,8 +52,8 @@ rustls-pemfile = "1.0.2"
 quick-xml.workspace = true
 derive_more.workspace = true
 uuid = { version = "1.3.0", features = ["v4"] }
-lavina-core = { path = "crates/lavina-core" }
+lavina-core.workspace = true
-proto-irc = { path = "crates/proto-irc" }
+projection-irc = { path = "crates/projection-irc" }
 proto-xmpp = { path = "crates/proto-xmpp" }
 mgmt-api = { path = "crates/mgmt-api" }
 clap.workspace = true

crates/lavina-core/src/lib.rs

@@ -1,7 +1,8 @@
 //! Domain definitions and implementation of common chat logic.
 pub mod player;
+pub mod prelude;
 pub mod repo;
 pub mod room;
+pub mod terminator;
 
-mod prelude;
 mod table;

crates/lavina-core/src/terminator.rs

@@ -0,0 +1,28 @@
+use crate::prelude::*;
+
+pub struct Terminator {
+    signal: Promise<()>,
+    completion: JoinHandle<Result<()>>,
+}
+impl Terminator {
+    pub async fn terminate(self) -> Result<()> {
+        match self.signal.send(()) {
+            Ok(()) => {}
+            Err(_) => log::warn!("Termination channel is dropped"),
+        }
+        self.completion.await??;
+        Ok(())
+    }
+
+    /// Used to spawn managed tasks with support for graceful shutdown
+    pub fn spawn<Fun, Fut>(launcher: Fun) -> Terminator
+    where
+        Fun: FnOnce(Deferred<()>) -> Fut,
+        Fut: Future<Output = Result<()>> + Send + 'static,
+    {
+        let (signal, rx) = oneshot();
+        let future = launcher(rx);
+        let completion = tokio::task::spawn(future);
+        Terminator { signal, completion }
+    }
+}

crates/projection-irc/Cargo.toml

@@ -0,0 +1,15 @@
+[package]
+name = "projection-irc"
+edition = "2021"
+version.workspace = true
+
+[dependencies]
+lavina-core.workspace = true
+tracing.workspace = true
+anyhow.workspace = true
+nonempty.workspace = true
+serde.workspace = true
+tokio.workspace = true
+prometheus.workspace = true
+proto-irc = { path = "../proto-irc" }
+futures-util.workspace = true

crates/projection-irc/src/lib.rs

@@ -1,11 +1,11 @@
 use std::collections::HashMap;
 use std::net::SocketAddr;
 
+use anyhow::{anyhow, Result};
 use futures_util::future::join_all;
 use nonempty::nonempty;
 use nonempty::NonEmpty;
 use prometheus::{IntCounter, IntGauge, Registry as MetricsRegistry};
-
 use serde::Deserialize;
 use tokio::io::{AsyncBufReadExt, AsyncWrite, AsyncWriteExt, BufReader, BufWriter};
 use tokio::net::tcp::{ReadHalf, WriteHalf};
@@ -13,17 +13,14 @@ use tokio::net::{TcpListener, TcpStream};
 use tokio::sync::mpsc::channel;
 
 use lavina_core::player::*;
+use lavina_core::prelude::*;
 use lavina_core::repo::Storage;
 use lavina_core::room::{RoomId, RoomInfo, RoomRegistry};
-use crate::prelude::*;
+use lavina_core::terminator::Terminator;
 use proto_irc::client::{client_message, ClientMessage};
 use proto_irc::server::{AwayStatus, ServerMessage, ServerMessageBody};
+use proto_irc::user::PrefixedNick;
 use proto_irc::{Chan, Recipient};
-use proto_irc::user::{Prefix, PrefixedNick};
-use crate::util::Terminator;
-
-#[cfg(test)]
-mod test;
 
 #[derive(Deserialize, Debug, Clone)]
 pub struct ServerConfig {
@@ -70,14 +67,12 @@ async fn handle_socket(
     .await?;
     writer.flush().await?;
 
-    let registered_user: Result<RegisteredUser> =
+    let registered_user: Result<RegisteredUser> = handle_registration(&mut reader, &mut writer, &mut storage).await;
-        handle_registration(&mut reader, &mut writer, &mut storage).await;
 
     match registered_user {
         Ok(user) => {
             log::debug!("User registered");
-            handle_registered_socket(config, players, rooms, &mut reader, &mut writer, user)
+            handle_registered_socket(config, players, rooms, &mut reader, &mut writer, user).await?;
-                .await?;
         }
         Err(_) => {
             log::debug!("Registration failed");
@@ -159,23 +154,22 @@ async fn handle_registration<'a>(
         buffer.clear();
     }?;
 
-
     let stored_user = storage.retrieve_user_by_name(&*user.nickname).await?;
 
     let stored_user = match stored_user {
         Some(u) => u,
         None => {
             log::info!("User '{}' not found", user.nickname);
-            return Err(fail("no user found"));
+            return Err(anyhow!("no user found"));
         }
     };
     if stored_user.password.is_none() {
         log::info!("Password not defined for user '{}'", user.nickname);
-        return Err(fail("password is not defined"));
+        return Err(anyhow!("password is not defined"));
     }
     if stored_user.password.as_deref() != pass.as_deref() {
         log::info!("Incorrect password supplied for user '{}'", user.nickname);
-        return Err(fail("passwords do not match"));
+        return Err(anyhow!("passwords do not match"));
     }
     // TODO properly implement session temination
 
@@ -250,14 +244,7 @@ async fn handle_registered_socket<'a>(
 
     let rooms_list = connection.get_rooms().await?;
     for room in &rooms_list {
-        produce_on_join_cmd_messages(
+        produce_on_join_cmd_messages(&config, &user, &Chan::Global(room.id.as_inner().clone()), room, writer).await?;
-            &config,
-            &user,
-            &Chan::Global(room.id.as_inner().clone()),
-            room,
-            writer,
-        )
-        .await?;
     }
 
     writer.flush().await?;
@@ -314,10 +301,7 @@ async fn handle_update(
 ) -> Result<()> {
     log::debug!("Sending irc message to player {player_id:?} on update {update:?}");
     match update {
-        Updates::RoomJoined {
+        Updates::RoomJoined { new_member_id, room_id } => {
-            new_member_id,
-            room_id,
-        } => {
             if player_id == &new_member_id {
                 if let Some(room) = rooms.get_room(&room_id).await {
                     let room_info = room.get_room_info().await;
@@ -438,16 +422,14 @@ async fn handle_incoming_message(
                 Recipient::Chan(Chan::Global(chan)) => {
                     let room_id = RoomId::from(chan)?;
                     user_handle.send_message(room_id, body).await?;
-                },
+                }
                 _ => log::warn!("Unsupported target type"),
             },
             ClientMessage::Topic { chan, topic } => {
                 match chan {
                     Chan::Global(chan) => {
                         let room_id = RoomId::from(chan)?;
-                        user_handle
+                        user_handle.change_topic(room_id.clone(), topic.clone()).await?;
-                            .change_topic(room_id.clone(), topic.clone())
-                            .await?;
                         ServerMessage {
                             tags: vec![],
                             sender: Some(config.server_name.clone()),
@@ -569,11 +551,7 @@ async fn handle_incoming_message(
     Ok(HandleResult::Continue)
 }
 
-fn user_to_who_msg(
+fn user_to_who_msg(config: &ServerConfig, requestor: &RegisteredUser, target_user_nickname: &Str) -> ServerMessageBody {
-    config: &ServerConfig,
-    requestor: &RegisteredUser,
-    target_user_nickname: &Str,
-) -> ServerMessageBody {
     // Username is equal to nickname
     let username = format!("~{target_user_nickname}").into();
 
@@ -674,8 +652,13 @@ async fn produce_on_join_cmd_messages(
     }
     .write_async(writer)
     .await?;
-    let prefixed_members: Vec<PrefixedNick> = room_info.members.iter().map(|member| PrefixedNick::from_str(member.clone().into_inner())).collect();
+    let prefixed_members: Vec<PrefixedNick> = room_info
-    let non_empty_members: NonEmpty<PrefixedNick> = NonEmpty::from_vec(prefixed_members).unwrap_or(nonempty![PrefixedNick::from_str(user.nickname.clone())]);
+        .members
+        .iter()
+        .map(|member| PrefixedNick::from_str(member.clone().into_inner()))
+        .collect();
+    let non_empty_members: NonEmpty<PrefixedNick> =
+        NonEmpty::from_vec(prefixed_members).unwrap_or(nonempty![PrefixedNick::from_str(user.nickname.clone())]);
 
     ServerMessage {
         tags: vec![],
@@ -710,12 +693,8 @@ pub async fn launch(
 ) -> Result<Terminator> {
     log::info!("Starting IRC projection");
     let (stopped_tx, mut stopped_rx) = channel(32);
-    let current_connections =
+    let current_connections = IntGauge::new("irc_current_connections", "Open and alive TCP connections")?;
-        IntGauge::new("irc_current_connections", "Open and alive TCP connections")?;
+    let total_connections = IntCounter::new("irc_total_connections", "Total number of opened connections")?;
-    let total_connections = IntCounter::new(
-        "irc_total_connections",
-        "Total number of opened connections",
-    )?;
     metrics.register(Box::new(current_connections.clone()))?;
     metrics.register(Box::new(total_connections.clone()))?;
 
@@ -780,7 +759,8 @@ pub async fn launch(
                     log::warn!("IRC connection to {socket_addr} finished with error: {err}")
                 }
             }
-        })).await;
+        }))
+        .await;
         log::info!("Stopped IRC projection");
         Ok(())
     });

src/main.rs

@@ -5,7 +5,6 @@
     impl_trait_in_assoc_type
 )]
 
-mod prelude;
 mod projections;
 mod util;
 
@@ -19,14 +18,14 @@ use prometheus::Registry as MetricsRegistry;
 use serde::Deserialize;
 
 use lavina_core::player::PlayerRegistry;
+use lavina_core::prelude::*;
 use lavina_core::repo::Storage;
 use lavina_core::room::RoomRegistry;
-use crate::prelude::*;
 
 #[derive(Deserialize, Debug)]
 struct ServerConfig {
     telemetry: util::telemetry::ServerConfig,
-    irc: projections::irc::ServerConfig,
+    irc: projection_irc::ServerConfig,
     xmpp: projections::xmpp::ServerConfig,
     storage: lavina_core::repo::StorageConfig,
 }
@@ -64,7 +63,7 @@ async fn main() -> Result<()> {
     let mut players = PlayerRegistry::empty(rooms.clone(), &mut metrics)?;
     let telemetry_terminator =
         util::telemetry::launch(telemetry_config, metrics.clone(), rooms.clone(), storage.clone()).await?;
-    let irc = projections::irc::launch(irc_config, players.clone(), rooms.clone(), metrics.clone(), storage.clone()).await?;
+    let irc = projection_irc::launch(irc_config, players.clone(), rooms.clone(), metrics.clone(), storage.clone()).await?;
     let xmpp = projections::xmpp::launch(xmpp_config, players.clone(), rooms.clone(), metrics.clone()).await?;
     tracing::info!("Started");
 

src/prelude.rs

@@ -1,25 +0,0 @@
-pub use std::future::Future;
-
-pub use tokio::pin;
-pub use tokio::select;
-pub use tokio::sync::oneshot::{channel as oneshot, Receiver as Deferred, Sender as Promise};
-pub use tokio::task::JoinHandle;
-
-pub mod log {
-    pub use tracing::{debug, error, info, warn};
-}
-
-pub type Result<T> = std::result::Result<T, anyhow::Error>;
-pub type Str = std::sync::Arc<str>;
-
-pub fn fail(msg: &str) -> anyhow::Error {
-    anyhow::Error::msg(msg.to_owned())
-}
-
-macro_rules! ffail {
-    ($($arg:tt)*) => {
-        fail(&format!($($arg)*))
-    };
-}
-
-pub(crate) use ffail;

src/projections/irc/test.rs

@@ -1,166 +0,0 @@
-use tokio::io::{AsyncBufReadExt, AsyncWriteExt, BufReader};
-use tokio::net::tcp::{ReadHalf, WriteHalf};
-use tokio::net::TcpStream;
-
-use crate::prelude::*;
-
-struct TestScope<'a> {
-    reader: BufReader<ReadHalf<'a>>,
-    writer: WriteHalf<'a>,
-    buffer: Vec<u8>,
-}
-impl<'a> TestScope<'a> {
-    async fn send(&mut self, str: &(impl AsRef<str> + ?Sized)) -> Result<()> {
-        self.writer.write_all(str.as_ref().as_bytes()).await?;
-        self.writer.flush().await?;
-        Ok(())
-    }
-
-    async fn expect(&mut self, str: &(impl AsRef<str> + ?Sized)) -> Result<()> {
-        let len = self.reader.read_until(b'\n', &mut self.buffer).await?;
-        assert_eq!(std::str::from_utf8(&self.buffer[0..len])?, str.as_ref());
-        self.buffer.clear();
-        Ok(())
-    }
-
-    async fn assert(&mut self, f: impl FnOnce(&str) -> Result<()>) -> Result<()> {
-        let len = self.reader.read_until(b'\n', &mut self.buffer).await?;
-        let res = f(std::str::from_utf8(&self.buffer[0..len])?);
-        self.buffer.clear();
-        res
-    }
-}
-
-async fn init_client(stream: &mut TcpStream) -> Result<TestScope> {
-    let (reader, writer) = stream.split();
-    let reader = BufReader::new(reader);
-    let buffer = vec![];
-    Ok(TestScope {
-        reader,
-        writer,
-        buffer,
-    })
-}
-
-macro_rules! send {
-    ($scope: expr, $($arg:tt),*) => {{
-        $scope.send(&format!($($arg,)*)).await?;
-    }};
-}
-
-macro_rules! expect {
-    ($scope: expr, $($arg:tt),*) => {{
-        $scope.expect(&format!($($arg,)*)).await?;
-    }};
-}
-
-const SERVER_HOSTNAME: &'static str = "irc.localhost";
-
-#[rustfmt::skip]
-async fn registration(scope: &mut TestScope<'_>, nickname: &str) -> Result<()> {
-    expect!(scope, ":irc.localhost NOTICE * :Welcome to my server!\r\n");
-    send!(scope, "NICK {nickname}\r\n");
-    send!(scope, "USER UserName 0 * :Real Name\r\n");
-    expect!(scope, ":irc.localhost 001 {nickname} :Welcome to Kek Server\r\n");
-    expect!(scope, ":irc.localhost 002 {nickname} :Welcome to Kek Server\r\n");
-    expect!(scope, ":irc.localhost 003 {nickname} :Welcome to Kek Server\r\n");
-    expect!(scope, ":irc.localhost 004 {nickname} irc.localhost kek-0.1.alpha.3 r CFILPQbcefgijklmnopqrstvz\r\n");
-    expect!(scope, ":irc.localhost 005 {nickname} CHANTYPES=# :are supported by this server\r\n");
-    Ok(())
-}
-
-#[rustfmt::skip]
-async fn join(scope: &mut TestScope<'_>, nickname: &str, chan: &str) -> Result<()> {
-    send!(scope, "JOIN #{chan}\r\n");
-    expect!(scope, ":{nickname} JOIN #{chan}\r\n");
-    expect!(scope, ":irc.localhost 332 {nickname} #{chan} :New room\r\n");
-    expect!(scope, ":irc.localhost 353 {nickname} = #{chan} :{nickname}\r\n");
-    expect!(scope, ":irc.localhost 366 {nickname} #{chan} :End of /NAMES list\r\n");
-    Ok(())
-}
-
-#[tokio::test]
-async fn test_registration() -> Result<()> {
-    let mut stream = TcpStream::connect("127.0.0.1:6667").await?;
-    let mut scope = init_client(&mut stream).await?;
-
-    registration(&mut scope, "NickName1").await?;
-    join(&mut scope, "NickName1", "chan1").await?;
-    Ok(())
-}
-
-#[rustfmt::skip]
-#[tokio::test]
-async fn test_two_connections_one_player() -> Result<()> {
-    let mut stream1 = TcpStream::connect("127.0.0.1:6667").await?;
-    let mut scope1 = init_client(&mut stream1).await?;
-    let mut stream2 = TcpStream::connect("127.0.0.1:6667").await?;
-    let mut scope2 = init_client(&mut stream2).await?;
-
-    let nickname = "NickName2";
-    let chan = "chan2";
-
-    registration(&mut scope1, nickname).await?;
-    registration(&mut scope2, nickname).await?;
-    join(&mut scope1, nickname, chan).await?;
-
-    // force join on second connection when the other one joins a room
-    expect!(scope2, ":{nickname} JOIN #{chan}\r\n");
-    expect!(scope2, ":{SERVER_HOSTNAME} 332 {nickname} #{chan} :New room\r\n");
-    expect!(scope2, ":{SERVER_HOSTNAME} 353 {nickname} = #{chan} :{nickname}\r\n");
-    expect!(scope2, ":{SERVER_HOSTNAME} 366 {nickname} #{chan} :End of /NAMES list\r\n");
-
-    // force send PRIVMSG to other connections
-    send!(scope1, "PRIVMSG #{chan} :Chmoki vsem v etam chati!\r\n");
-    expect!(scope2, ":{nickname} PRIVMSG #{chan} :Chmoki vsem v etam chati!\r\n");
-    send!(scope2, "PRIVMSG #{chan} :I tebe privetiki\r\n");
-    expect!(scope1, ":{nickname} PRIVMSG #{chan} :I tebe privetiki\r\n");
-
-    let mut stream3 = TcpStream::connect("127.0.0.1:6667").await?;
-    let mut scope3 = init_client(&mut stream3).await?;
-    registration(&mut scope3, nickname).await?;
-
-    // force join on registration
-    expect!(scope3, ":{nickname} JOIN #{chan}\r\n");
-    expect!(scope3, ":{SERVER_HOSTNAME} 332 {nickname} #{chan} :New room\r\n");
-    expect!(scope3, ":{SERVER_HOSTNAME} 353 {nickname} = #{chan} :{nickname}\r\n");
-    expect!(scope3, ":{SERVER_HOSTNAME} 366 {nickname} #{chan} :End of /NAMES list\r\n");
-
-    Ok(())
-}
-
-#[rustfmt::skip]
-#[tokio::test]
-async fn test_two_players() -> Result<()> {
-    let mut stream1 = TcpStream::connect("127.0.0.1:6667").await?;
-    let mut scope1 = init_client(&mut stream1).await?;
-    let mut stream2 = TcpStream::connect("127.0.0.1:6667").await?;
-    let mut scope2 = init_client(&mut stream2).await?;
-
-    let nickname1 = "NickName3";
-    let nickname2 = "NickName4";
-
-    let chan = "chan3";
-
-    registration(&mut scope1, "NickName3").await?;
-    registration(&mut scope2, "NickName4").await?;
-    join(&mut scope1, nickname1, "chan3").await?;
-    send!(scope2, "JOIN #{chan}\r\n");
-    expect!(scope2, ":{nickname2} JOIN #{chan}\r\n");
-    expect!(scope2, ":irc.localhost 332 {nickname2} #{chan} :New room\r\n");
-    scope2.assert(|line| {
-        if line == format!(":irc.localhost 353 {nickname2} = #{chan} :{nickname1} {nickname2}\r\n") { return Ok(()) }
-        if line == format!(":irc.localhost 353 {nickname2} = #{chan} :{nickname2} {nickname1}\r\n") { return Ok(()) }
-        panic!("incorrect chan member list received: {line}");
-    }).await?;
-    expect!(scope2, ":irc.localhost 366 {nickname2} #{chan} :End of /NAMES list\r\n");
-
-    expect!(scope1, ":{nickname2} JOIN #{chan}\r\n");
-
-    send!(scope1, "PRIVMSG #chan3 :Chmoki vsem v etam chati!\r\n");
-    expect!(scope2, ":{nickname1} PRIVMSG #chan3 :Chmoki vsem v etam chati!\r\n");
-    send!(scope2, "PRIVMSG #chan3 :I tebe privetiki\r\n");
-    expect!(scope1, ":{nickname2} PRIVMSG #chan3 :I tebe privetiki\r\n");
-
-    Ok(())
-}

src/projections/mod.rs

@@ -1,3 +1,2 @@
 //! Protocol projections — implementations of public APIs.
-pub mod irc;
 pub mod xmpp;

src/projections/xmpp/mod.rs

@@ -20,8 +20,9 @@ use tokio_rustls::rustls::{Certificate, PrivateKey};
 use tokio_rustls::TlsAcceptor;
 
 use lavina_core::player::{PlayerConnection, PlayerId, PlayerRegistry};
+use lavina_core::prelude::*;
 use lavina_core::room::{RoomId, RoomRegistry};
-use crate::prelude::*;
+use lavina_core::terminator::Terminator;
 use proto_xmpp::bind::{BindResponse, Jid, Name, Resource, Server};
 use proto_xmpp::client::{Iq, Message, MessageType, Presence};
 use proto_xmpp::disco::*;
@@ -29,7 +30,6 @@ use proto_xmpp::roster::RosterQuery;
 use proto_xmpp::session::Session;
 use proto_xmpp::stream::*;
 use proto_xmpp::xml::{Continuation, FromXml, Parser, ToXml};
-use crate::util::Terminator;
 
 use self::proto::{ClientPacket, IqClientBody};
 

src/projections/xmpp/proto.rs

@@ -1,7 +1,9 @@
+use anyhow::anyhow;
 use derive_more::From;
 use quick_xml::events::Event;
 use quick_xml::name::{Namespace, ResolveResult};
 
+use lavina_core::prelude::*;
 use proto_xmpp::bind::BindRequest;
 use proto_xmpp::client::{Iq, Message, Presence};
 use proto_xmpp::disco::{InfoQuery, ItemQuery};
@@ -9,8 +11,6 @@ use proto_xmpp::roster::RosterQuery;
 use proto_xmpp::session::Session;
 use proto_xmpp::xml::*;
 
-use crate::prelude::*;
-
 #[derive(PartialEq, Eq, Debug, From)]
 pub enum IqClientBody {
     Bind(BindRequest),
@@ -29,7 +29,7 @@ impl FromXml for IqClientBody {
             let bytes = match event {
                 Event::Start(bytes) => bytes,
                 Event::Empty(bytes) => bytes,
-                _ => return Err(ffail!("Unexpected XML event: {event:?}")),
+                _ => return Err(anyhow!("Unexpected XML event: {event:?}")),
             };
             let name = bytes.name();
             match_parser!(name, namespace, event;
@@ -67,7 +67,7 @@ impl FromXml for ClientPacket {
                         Presence::<Ignore>,
                         Message,
                         {
-                            Err(ffail!(
+                            Err(anyhow!(
                                 "Unexpected XML event of name {:?} in namespace {:?}",
                                 name,
                                 namespace
@@ -80,11 +80,11 @@ impl FromXml for ClientPacket {
                     if name.local_name().as_ref() == b"stream" {
                         return Ok(ClientPacket::StreamEnd);
                     } else {
-                        return Err(ffail!("Unexpected XML event: {event:?}"));
+                        return Err(anyhow!("Unexpected XML event: {event:?}"));
                     }
                 }
                 _ => {
-                    return Err(ffail!("Unexpected XML event: {event:?}"));
+                    return Err(anyhow!("Unexpected XML event: {event:?}"));
                 }
             }
         }

src/util/mod.rs

@@ -1,32 +1,3 @@
-use crate::prelude::*;
-
 pub mod telemetry;
 #[cfg(test)]
 pub mod testkit;
-
-pub struct Terminator {
-    signal: Promise<()>,
-    completion: JoinHandle<Result<()>>,
-}
-impl Terminator {
-    pub async fn terminate(self) -> Result<()> {
-        match self.signal.send(()) {
-            Ok(()) => {}
-            Err(_) => log::warn!("Termination channel is dropped"),
-        }
-        self.completion.await??;
-        Ok(())
-    }
-
-    /// Used to spawn managed tasks with support for graceful shutdown
-    pub fn spawn<Fun, Fut>(launcher: Fun) -> Terminator
-    where
-        Fun: FnOnce(Deferred<()>) -> Fut,
-        Fut: Future<Output = Result<()>> + Send + 'static,
-    {
-        let (signal, rx) = oneshot();
-        let future = launcher(rx);
-        let completion = tokio::task::spawn(future);
-        Terminator { signal, completion }
-    }
-}

src/util/telemetry.rs

@@ -11,10 +11,10 @@ use prometheus::{Encoder, Registry as MetricsRegistry, TextEncoder};
 use serde::{Deserialize, Serialize};
 use tokio::net::TcpListener;
 
+use lavina_core::prelude::*;
 use lavina_core::repo::Storage;
 use lavina_core::room::RoomRegistry;
-use crate::prelude::*;
+use lavina_core::terminator::Terminator;
-use crate::util::Terminator;
 
 use mgmt_api::*;
 

src/util/testkit.rs

@@ -2,7 +2,7 @@ use std::task::{Context, Poll};
 
 use futures_util::task::noop_waker_ref;
 
-use crate::prelude::*;
+use lavina_core::prelude::*;
 
 pub fn sync_future<T>(future: impl Future<Output = T>) -> Result<T> {
     let waker = noop_waker_ref();