Nikita Vilunov nikita
  • Joined on 2023-08-25
nikita opened issue lavina/lavina#10 2023-09-15 19:57:20 +00:00
Maintenance API
nikita pushed to main at lavina/lavina 2023-09-15 16:33:26 +00:00
87d73af811 [irc] used nonempty prefixed nicks in 353 reply (#9)
nikita merged pull request lavina/lavina#9 2023-09-15 16:33:26 +00:00
[irc] used nonempty prefixed nicks in 353 reply
nikita pushed to main at lavina/lavina 2023-09-15 15:20:32 +00:00
298245f3f5 bump version
3de7a131f0 add dockerfile
Compare 2 commits »
nikita pushed tag 0.0.0 to lavina/lavina 2023-09-15 15:12:17 +00:00
nikita pushed to main at lavina/lavina 2023-09-14 16:55:11 +00:00
c662b64f11 disable tls support in sqlx, remove webpki-roots
nikita commented on pull request lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply

core is not really a good module to put prefix-related types, since they are irc-specific.

nikita commented on pull request lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply

it's probably okay to make it just a Str, since this is the domain of irc and it doesn't have players, it has nicknames and usernames and other stuff (which probably could be wrapped into newtypes in future)

nikita commented on pull request lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply

it was deliberately made non-pub, because I want to limit the creation of PlayerIds to the smart constructor PlayerId::from, which validates the format and returns the values if all is fine

nikita suggested changes for lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply
nikita commented on pull request lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply

this is not the way, you should actually iterate over members in a for-loop and call writer.write_all there

nikita commented on pull request lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply

also according to the rust code style variables are named in snake_case and not in camelCase

nikita commented on pull request lavina/lavina#9 2023-09-08 17:55:29 +00:00
[irc] used nonempty prefixed nicks in 353 reply

unwrap crashes the app here, also not needed since the constructor doesn't fail and can return just raw value without Result

nikita opened issue lavina/lavina#8 2023-09-06 19:29:41 +00:00
Non-PASS authentication in IRC
nikita pushed to main at lavina/lavina 2023-09-06 18:43:09 +00:00
53f218c58f [irc] send 502 if not sender tries to change mode for other users (#4)
nikita merged pull request lavina/lavina#4 2023-09-06 18:43:08 +00:00
[irc] send 502 if not sender tries to change mode for other users
nikita opened issue lavina/lavina#7 2023-09-06 18:26:35 +00:00
Plaintext authentication in XMPP
nikita opened issue lavina/lavina#6 2023-09-06 18:22:30 +00:00
Sanitize XMPP parsing
nikita opened issue lavina/lavina#5 2023-09-06 18:18:17 +00:00
Persistence MVP
nikita created pull request lavina/lavina#3 2023-09-06 17:23:30 +00:00
Introduce scoped async tasks and get-rid of Arc'ed objects