[T; 20]
is an array of 20 elements exactly, and there might be fewer that 20 elements?
All protocol types like any other network-transmitted types are plain data, they have no encapsulation of data and no behavior other than [de]serialization. This concerns all that kind of types,…
it's better to move this entire module to proto-irc
, make all fields public and remove new
methods
probably rename this to IrcConnection
just like we already have an XmppConnection
I would prefer that all player-related queries would go through PlayerConnection
and then the player actor, Storage
should not be exposed to projections. Even if the method in PlayerConnection
does nothing except calling storage. This is important because 1) the player actor serializes all incoming commands and acts as a sort of anti-dos protection layer; 2) it's not guaranteed in the future that all players will be stored on the same node, and the core services will handle routing requests to other nodes.