diff --git a/CHANGELOG.md b/CHANGELOG.md index 20ac934..909ab86 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ - Fixed visual issues with the fade out effect. - Fixed visual glitch at the last beat of a loop. - Fixed timings of one of the tracks. +- Removed unnecessary "Enable Color Animations" config option. ## MuzikaGromche 13.37.911 - Sri Lanka Bus hotfix diff --git a/MuzikaGromche/Plugin.cs b/MuzikaGromche/Plugin.cs index db2e428..295d60f 100644 --- a/MuzikaGromche/Plugin.cs +++ b/MuzikaGromche/Plugin.cs @@ -1196,18 +1196,15 @@ namespace MuzikaGromche float transitionLength = track.ColorTransitionIn + track.ColorTransitionOut; - if (Config.EnableColorAnimations.Value) + if (transitionLength > /* epsilon */ 0.01) { - if (transitionLength > /* epsilon */ 0.01) + if (BeatTimeSpan.Between(currentClipStart, timestamp).Duration() < track.ColorTransitionOut) { - if (BeatTimeSpan.Between(currentClipStart, timestamp).Duration() < track.ColorTransitionOut) - { - return ColorTransition(currentClipStart); - } - else if (BeatTimeSpan.Between(timestamp, currentClipEnd).Duration() < track.ColorTransitionIn) - { - return ColorTransition(currentClipEnd); - } + return ColorTransition(currentClipStart); + } + else if (BeatTimeSpan.Between(timestamp, currentClipEnd).Duration() < track.ColorTransitionIn) + { + return ColorTransition(currentClipEnd); } } // default @@ -1409,8 +1406,6 @@ namespace MuzikaGromche public class Config : SyncedConfig2 { - public static ConfigEntry EnableColorAnimations { get; private set; } = null!; - public static ConfigEntry DisplayLyrics { get; private set; } = null!; public static ConfigEntry AudioOffset { get; private set; } = null!; @@ -1432,10 +1427,6 @@ namespace MuzikaGromche public Config(ConfigFile configFile) : base(PluginInfo.PLUGIN_GUID) { - EnableColorAnimations = configFile.Bind("General", "Enable Color Animations", true, - new ConfigDescription("Smooth light color transitions are known to cause performance issues on some setups.\n\nTurn them off if you experience lag spikes.")); - LethalConfigManager.AddConfigItem(new BoolCheckBoxConfigItem(EnableColorAnimations, requiresRestart: false)); - DisplayLyrics = configFile.Bind("General", "Display Lyrics", true, new ConfigDescription("Display lyrics in the HUD tooltip when you hear the music.")); LethalConfigManager.AddConfigItem(new BoolCheckBoxConfigItem(DisplayLyrics, requiresRestart: false));