caffeinatedgaze

caffeinatedgaze commented on pull request lavina/lavina#70

2024-06-03 14:34:29 +00:00

reduce usage of unwraps

Isn't it better to fail early here so that we can see the error trace and stuff?

caffeinatedgaze commented on pull request lavina/lavina#70

2024-06-03 14:26:18 +00:00

reduce usage of unwraps

Are we ideally supposed to fetch and return the topic too?

caffeinatedgaze commented on pull request lavina/lavina#70

2024-06-03 14:20:06 +00:00

reduce usage of unwraps

A bit unclear what i, k, and j are. Is it an idiom?

caffeinatedgaze commented on pull request lavina/lavina#70

2024-06-03 14:16:19 +00:00

reduce usage of unwraps

todo: replace with a custom ADT.

caffeinatedgaze commented on pull request lavina/lavina#70

2024-06-03 13:43:38 +00:00

reduce usage of unwraps

and Ok(Err(<...>) on error?

caffeinatedgaze commented on pull request lavina/lavina#70

2024-06-03 13:43:15 +00:00

reduce usage of unwraps

Would it return Ok(Ok(<...>)) before?

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-30 22:25:39 +00:00

0554f3635a Add todos

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-30 22:22:58 +00:00

ba26e833e4 Handle cap correctly and test

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-30 21:57:18 +00:00

dfc28148e5 Remove excessive db call

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-30 18:12:55 +00:00

ae0464b742 Handle non-negotiated cap

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-30 18:05:34 +00:00

a3e41ad11d Rollback to Chan

caffeinatedgaze opened issue lavina/lavina#74

2024-05-29 09:25:45 +00:00

Presence from an IRC user joining is not visible to an XMPP member

caffeinatedgaze commented on issue lavina/lavina#72

2024-05-29 09:20:14 +00:00

Broadcast does not cover all of the subscribers

This was a regression. Requires a test case.

Fix
Test case

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-28 19:24:49 +00:00

7efbea7b71 Test ordering and limits

2ffe3ba197 Test chathistory

Compare 2 commits »

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-28 18:59:50 +00:00

1e8a183d6c Implement limit

caffeinatedgaze created pull request lavina/lavina#73

2024-05-28 18:47:12 +00:00

WIP: #39-irc-chathistory

caffeinatedgaze created branch #39-irc-chathistory in caffeinatedgaze/lavina

2024-05-28 18:39:08 +00:00

caffeinatedgaze pushed to #39-irc-chathistory at caffeinatedgaze/lavina

2024-05-28 18:39:08 +00:00

b0789d5457 Send messages on join

b3d27e96c2 Parse chathistory command

fac20a215d Add chathistory cap

1a21c05d7d xmpp: add support leaving MUCs via unavailable presence (#71)

43d105ab23 core: subscribe to rooms on player actor startup

Compare 7 commits »

caffeinatedgaze opened issue lavina/lavina#72

2024-05-26 16:52:57 +00:00

Broadcast does not cover all of the subscribers

caffeinatedgaze pushed to feature/muc-join-messages at caffeinatedgaze/lavina

2024-05-25 17:10:09 +00:00

ca908dea12 Change from to try_from